Added missing default style for FileField #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks right, tho surprised. Is file input currently just not available at all in the 3.0 browsable API? If you're feeling enthusiastic could you also screenshot before & after and attach to this ticket? |
|
Otherwise ready for merge, once we've got the extra confirmation. |
|
|
|
Yeah. It looks like you patched the templates but forgot to include the FileField information in renderer at this commit: 5f580ca and that commit closed my PR |
tomchristie
added a commit
that referenced
this pull request
Dec 4, 2014
Added missing default style for FileField
This was referenced Mar 9, 2017
This was referenced Oct 16, 2017
This was referenced Nov 6, 2017
This was referenced Dec 10, 2017
This was referenced Dec 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked this commit from the PR I submitted at #2065. This change is needed to enable file input.